Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Quote Functionality for CardDiscussionInput #1165

Merged
merged 3 commits into from
Mar 22, 2025

Conversation

arelymartinez16
Copy link
Contributor

Contributor checklist


Description

This change improves the user experience by making quoted content appear as expected in discussions.

Changes:

  • Updated blockquote() function to use toggleBlockquote() instead of toggleCodeBlock()
  • Added appropriate Tailwind styling for blockquotes to make them visually distinct but more user-friendly
  • Ensured consistent styling between light and dark modes

Related issue

Copy link

netlify bot commented Mar 18, 2025

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 623fe74
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/67dec1d98fab67000829fd16
😎 Deploy Preview https://deploy-preview-1165--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Thank you for the pull request! ❤️

The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider attending our bi-weekly Saturday developer syncs! It'd be great to meet you 😊

Copy link
Contributor

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The TypeScript, pytest and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo (can be set with git config --global user.email "GITHUB_EMAIL")

@andrewtavis andrewtavis self-requested a review March 18, 2025 07:30
@andrewtavis
Copy link
Member

Thanks for this, @arelymartinez16! We'll try to get to the review in the coming days :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All's looking great here, @arelymartinez16! Really appreciate this fantastic first commit. I did a quick edit for styling so it uses our custom colors, as those are defined in frontend/assets/css/tailwind.css and include dark and light mode variants 😊

Hope we can work with you again!

@andrewtavis andrewtavis merged commit 7664f40 into activist-org:main Mar 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants