-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing test for backend/communities/organizations/models.py 🧪 #1166
missing test for backend/communities/organizations/models.py 🧪 #1166
Conversation
✅ Deploy Preview for activist-org canceled.
|
Thank you for the pull request! ❤️The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
No stress on the build errors, @Abhi-Bohora. There's something with how it's aligning with Netlify that's the problem. I'll look into this :) |
Frontend tests are going to fail on the above build, @Abhi-Bohora. The header rules are fixed, but for some reason we're getting a frontend error in node_modules right now 🤔 If you have any suggestions here, feel free to let us know! Obviously not a part of what you're doing here, but figured I'd ask :) CC @mattburnett-repo who I'll also ask about thin in #1164 |
CC @cquinn540 here as well :) This PR is simple, so maybe we can get the fix in here as it'll be in before @mattburnett-repo's in #1164. We had a dependency warning and I updated Babel for it. That dropped Netlify support until I updated to a patch version, but now we have a random frontend error in |
Hmm, It seems like somehow it is redefining the This error originated in "test/components/dropdown/DropdownTheme.spec.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running. and This error originated in "test/pages/auth/sign-in.spec.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running |
@andrewtavis opened to PR to fix the frontend test typescript error: #1167 |
Thanks @cquinn540! Just got back from a mini vacation and right back into work :) Really appreciate the help here! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for keeping at this, @Abhi-Bohora! Just a bit more to go before we close #1134! 😊
Contributor checklist
Description
This PR covers the missing test for
backend/communities/organizations/models.py 71 4 94% 71, 79, 88, 131
This test the string representation methods of several model classes in
organizations/models.py
Related issue