Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing test for backend/communities/organizations/models.py 🧪 #1166

Merged
merged 4 commits into from
Mar 19, 2025

Conversation

Abhi-Bohora
Copy link
Contributor

Contributor checklist


Description

This PR covers the missing test for backend/communities/organizations/models.py 71 4 94% 71, 79, 88, 131

This test the string representation methods of several model classes in organizations/models.py

Related issue

Copy link

netlify bot commented Mar 18, 2025

Deploy Preview for activist-org canceled.

Name Link
🔨 Latest commit db88c96
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/67da94277279770008bafec1

Copy link
Contributor

Thank you for the pull request! ❤️

The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider attending our bi-weekly Saturday developer syncs! It'd be great to meet you 😊

Copy link
Contributor

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The TypeScript, pytest and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

No stress on the build errors, @Abhi-Bohora. There's something with how it's aligning with Netlify that's the problem. I'll look into this :)

@andrewtavis
Copy link
Member

Frontend tests are going to fail on the above build, @Abhi-Bohora. The header rules are fixed, but for some reason we're getting a frontend error in node_modules right now 🤔 If you have any suggestions here, feel free to let us know! Obviously not a part of what you're doing here, but figured I'd ask :)

CC @mattburnett-repo who I'll also ask about thin in #1164

@andrewtavis
Copy link
Member

andrewtavis commented Mar 18, 2025

CC @cquinn540 here as well :) This PR is simple, so maybe we can get the fix in here as it'll be in before @mattburnett-repo's in #1164. We had a dependency warning and I updated Babel for it. That dropped Netlify support until I updated to a patch version, but now we have a random frontend error in node_modules/@nuxtjs/i18n/dist/runtime/plugins/i18n.js:167:18 that we can see four times when running sudo yarn test in the frontend 🤔

@Abhi-Bohora
Copy link
Contributor Author

Hmm, It seems like somehow it is redefining the locales and giving this error TypeError: Cannot redefine property: locales
And that error is generated from 2 different files while it is running

This error originated in "test/components/dropdown/DropdownTheme.spec.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.

and

This error originated in "test/pages/auth/sign-in.spec.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running

@cquinn540
Copy link
Collaborator

@andrewtavis opened to PR to fix the frontend test typescript error: #1167

@andrewtavis
Copy link
Member

Thanks @cquinn540! Just got back from a mini vacation and right back into work :) Really appreciate the help here! 😊

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping at this, @Abhi-Bohora! Just a bit more to go before we close #1134! 😊

@andrewtavis andrewtavis merged commit 8b71bb6 into activist-org:main Mar 19, 2025
7 checks passed
@Abhi-Bohora Abhi-Bohora deleted the organizations/models.py branch March 19, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants