Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the __str__ method of different models in backend/content/models.py and backend/events/models.py🧪 #1170

Merged
merged 2 commits into from
Mar 22, 2025

Conversation

Abhi-Bohora
Copy link
Contributor

@Abhi-Bohora Abhi-Bohora commented Mar 20, 2025

Contributor checklist


Description

This test the adds the missing test coverage for
backend/content/models.py 111 8 93% 27, 40, 51, 64, 98, 110, 120, 166 and backend/events/models.py 71 1 99% 124

Related issue

Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for activist-org canceled.

Name Link
🔨 Latest commit 2164af9
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/67dbf1c35d0a0300082ebda5

Copy link
Contributor

Thank you for the pull request! ❤️

The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider attending our bi-weekly Saturday developer syncs! It'd be great to meet you 😊

Copy link
Contributor

github-actions bot commented Mar 20, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The TypeScript, pytest and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@Abhi-Bohora
Copy link
Contributor Author

@andrewtavis Hello 👋 Now one last test is remaining 😊and than maybe we can increase the coverage in pr_ci_backend.yaml file to see up to what we can increase

@andrewtavis
Copy link
Member

Nice, @Abhi-Bohora! Do you want to add that test to this PR and then we can also change the coverage percent as well?

@Abhi-Bohora
Copy link
Contributor Author

@andrewtavis Done. Now all the test are completed of issue #1134

@Abhi-Bohora Abhi-Bohora changed the title Test the __str__ method of different models in backend/content/models.py 🧪 Test the __str__ method of different models in backend/content/models.py and backend/events/models.py🧪 Mar 20, 2025
@andrewtavis andrewtavis self-requested a review March 22, 2025 13:14
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All's looking great here, @Abhi-Bohora! Thanks for the amazing work on these tests :) Hope to see you in the sync later today! Let's definitely discuss a next issue either there or async 😊

@andrewtavis andrewtavis merged commit ceb8953 into activist-org:main Mar 22, 2025
7 checks passed
@Abhi-Bohora Abhi-Bohora deleted the content/models.py branch March 22, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants