actix ws more tests #622
Merged
actix ws more tests #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes an ignored failing test for actix#607
robjtede
added
B-semver-norelease
robjtede
reviewed
Nov 11, 2025
actix-ws/src/aggregated.rs
Outdated
Comment on lines
229
to
232
| tokio::runtime::Builder::new_current_thread() | ||
| .build() | ||
| .unwrap() | ||
| .block_on(async move { |
Member
There was a problem hiding this comment.
just wondering... this is effectively the tokio::test macro, no?
Contributor
Author
There was a problem hiding this comment.
Yeah. Looking at the docs it seems tokio calls .enable_all() on the builder and we don't need that, but it probably doesn't hurt
robjtede
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Tests
PR Checklist
cargo +nightly fmt).Overview
Add tests for MessageStream and AggregatedMessageStream (previous PR was misnamed, it tested StreamingBody)
One of the included AggregatedMessageStream tests fails and is ignored, but should pass with #607