fix(actix-ws): Continuation frames might get stuck or delayed in AggregatedMessageStream #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asonix
approved these changes
Jan 8, 2026
Contributor
asonix
left a comment
asonix
left a comment
There was a problem hiding this comment.
IMO I'd rather the original author get credit for this fix, but I also think getting the fix merged in some form is important. If someone with commit access to this repo has time to spare, they could merge the original PR and uncomment the test themselves
Member
|
Or, could you cherry-pick the original commits then add your commits there? In that way, we can keep credits. |
Author
|
Fixed in #607, thanks! closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Bug Fix
PR Checklist
cargo +nightly fmt).Overview
Trying to merge #607 since original author @liuzsen is not reponding. Changes have already been reviewed by @asonix ,
I've only unignored corresponding test from main branch and added changelog entry. All props to @liuzsen for finding and fixing this bug.
And Im perfectly fine with closing this PR and merging #607, just want the fix.
Closes #607