Open
Conversation
JohnTitor
requested changes
Feb 15, 2026
Comment on lines
+153
to
+154
| log::error!("Specified path is not a directory: {:?}", orig_dir); | ||
| orig_dir |
Member
There was a problem hiding this comment.
Why did you remove the comment?
|
|
||
| // full file path | ||
| let path = this.directory.join(&path_on_disk); | ||
| // Try to find file in multiple directories |
Member
There was a problem hiding this comment.
This breaks our current behavior, in particular for try_compressed.
Comment on lines
-117
to
+120
| let dir = Directory::new(self.directory.clone(), path); | ||
| let dir = Directory::new(path.clone(), path); |
Member
There was a problem hiding this comment.
This changes semantics, why do you need change base?
| let mut found_path = None; | ||
| let mut last_err = None; | ||
|
|
||
| for directory in &this.directories { |
Member
There was a problem hiding this comment.
This won't work if Files::new_from_array("/", &["./dist", "./public"]).index_file("index.html") is passed and you want to look up ./public/index.html.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Overview
Add
Files::new_from_array()andFiles::new_multiple()methods to support multiple directories from array and iterator, and implement multi-directory static file serving with priority order.Close #3402