Skip to content

ci: Add a C++23 build#5223

Merged
kodiakhq[bot] merged 28 commits into
acts-project:mainfrom
paulgessinger:ci/cpp23
Mar 18, 2026
Merged

ci: Add a C++23 build#5223
kodiakhq[bot] merged 28 commits into
acts-project:mainfrom
paulgessinger:ci/cpp23

Conversation

@paulgessinger

Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot added this to the next milestone Mar 9, 2026
@github-actions github-actions Bot added the Infrastructure Changes to build tools, continous integration, ... label Mar 9, 2026
@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

📊: Physics performance monitoring for 7932591

Full contents

physmon summary

❗️: Downstream build failure

  • Key4hep (cc @acts-project/key4hep-contacts)

@paulgessinger

Copy link
Copy Markdown
Member Author

I suppose the test failure is due to this: #5228

@github-actions github-actions Bot added the Component - Examples Affects the Examples module label Mar 13, 2026
Comment thread CI/dependencies/select_lockfile.py
Comment thread CI/physmon/reference/simulation/particles_geant4_hist.root
Comment thread Examples/Scripts/Python/gnn.py
Comment thread Python/Examples/tests/root_file_hashes.txt
Comment thread Python/Examples/tests/test_examples.py
Comment thread CI/dependencies/select_lockfile.py Outdated
Comment thread CI/dependencies/select_lockfile.py
Comment thread CI/dependencies/select_lockfile.py
Comment thread CI/dependencies/select_lockfile.py Outdated
Comment thread CI/dependencies/select_lockfile.py Outdated
@paulgessinger

Copy link
Copy Markdown
Member Author

@AJPfleger I tried to simplify the lockfile selection with a more explicit sequence and fallback outputs.

@paulgessinger paulgessinger requested a review from AJPfleger March 18, 2026 13:07
@sonarqubecloud

Copy link
Copy Markdown

@kodiakhq kodiakhq Bot merged commit d157670 into acts-project:main Mar 18, 2026
42 checks passed
kodiakhq Bot pushed a commit that referenced this pull request Mar 20, 2026
After #5223 I cannot locally compile `Examples/Detectors/MuonSpectrometerMockupDetector/src/GeoMuonMockupExperiment.cpp` anymore. I suspect that the captured lambda does not trigger the type switch correctly while using `auto` does because the lambda will be effectively templated.
@andiwand andiwand modified the milestones: next, v46.0.0 Mar 23, 2026
benjaminhuth pushed a commit to benjaminhuth/acts that referenced this pull request Mar 23, 2026
After acts-project#5223 I cannot locally compile `Examples/Detectors/MuonSpectrometerMockupDetector/src/GeoMuonMockupExperiment.cpp` anymore. I suspect that the captured lambda does not trigger the type switch correctly while using `auto` does because the lambda will be effectively templated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes Performance Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants