refactor!: Make stepper bound params more explicit for propagation#5240
Merged
kodiakhq[bot] merged 5 commits intoMar 19, 2026
Merged
Conversation
github-actions
Bot
added
Component - Core
Contributor
|
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jun 12, 2026
Deletes the unused files that are detected in: - #5075 and have been missed in: - #5074 I would suggest to add them for now to the ignore list in the unused file check and remove the entries with this PR together with the files. Therefore blocked by: - #5075 ### `Core/include/Acts/EventData/detail/ParameterTraits.hpp` This one is ancient. Hasn't been updated for 6 years. It was missed in the file check, because `Core/include/Acts/Propagator/Propagator.hpp` included `ParameterTraits` from `Core/include/Acts/Propagator/detail/ParameterTraits.hpp`. This was removed in: - #5240 ### `Core/include/Acts/Seeding/PathSeeder.hpp` This was only used by `Tests/UnitTests/Core/Seeding/PathSeederTest.cpp`, which was removed in: - #5261 ### `Tests/CommonHelpers/include/ActsTests/CommonHelpers/TestSpacePoint.hpp` This was only used by `Tests/UnitTests/Core/SpacePointFormation/SpacePointBuilderTests.cpp`, which was removed in: - #5261
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the way how the bound parameters type is inferred from the
Stepperto thePropagatorby requiring a typedef on the and consistently passing using that type.Also
StepperConceptto narrow the template param of the steppermakeResultfunction--- END COMMIT MESSAGE ---
After a discussion with @benjaminhuth we believe that this is better than #5139 in order not to narrow the propagation down to a single type but rather keep the flexibility modeled through the type system.