fix: Make comments appear in the Key4hep workflow#5260
Closed
jmcarcell wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
the
Infrastructure
- Always check for comment artifacts instead of checking only if physmon succeeded - Also run get-pr-number and downstream when there are comments to write - Don't fail if physmon is not found when writing the comment - Make sure to check == 'true' since "false" is true in JS
Contributor
Member
Author
|
Ah sorry I didn't see the message was there originally. It was just ignored. Maybe not so easy to see 🤔 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--- END COMMIT MESSAGE ---
This is my attempt. Currently the Key4hep workflow doesn't work after
#5076 but it fails and no comment is written. If this is correct, then it should appear here.