chore: bump ModuleMapGraph to version 1.4.0#5269
Merged
benjaminhuth merged 12 commits intoMar 22, 2026
Merged
Conversation
Headers moved from flat namespace to MMG/ subdirectory in v1.4.0. Update all includes accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The old module map ROOT files stored cut parameters as Double_t branches, which is incompatible with v1.4.0's Float_t reader. Switch to the new pre-built files in new_module_map/ which match the new format. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
benjaminhuth
force-pushed
the
feature/update-mmg-to-1-4
branch
from
412131c to
5f3d9c1
Compare
paulgessinger
previously approved these changes
Mar 20, 2026
github-actions
Bot
added
Infrastructure
Contributor
|
AJPfleger
approved these changes
Mar 22, 2026
benjaminhuth
added a commit
to benjaminhuth/acts
that referenced
this pull request
Mar 23, 2026
Requires a new module map file due to changes in the definition of the geometric cuts. For now, the new patched module map files have the min/max values of the affected `deta` and `diff_dydx` cuts inflated to `+/- inf` to avoid regeneration of the module map files. Should go in after acts-project#5263 --- END COMMIT MESSAGE --- Any further description goes here, @-mentions are ok here! - Use a *conventional commits* prefix: [quick summary](https://www.conventionalcommits.org/en/v1.0.0/#summary) - We mostly use `feat`, `fix`, `refactor`, `docs`, `chore` and `build` types. - A milestone will be assigned by one of the maintainers --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires a new module map file due to changes in the definition of the geometric cuts. For now, the new patched module map files have the min/max values of the affected
detaanddiff_dydxcuts inflated to+/- infto avoid regeneration of the module map files.Should go in after #5263
--- END COMMIT MESSAGE ---
Any further description goes here, @-mentions are ok here!
feat,fix,refactor,docs,choreandbuildtypes.