feat: Include the container name when using grouping in blueprint construction#5368
Open
tmadlener wants to merge 1 commit into
Open
feat: Include the container name when using grouping in blueprint construction#5368tmadlener wants to merge 1 commit into
tmadlener wants to merge 1 commit into
Conversation
Avoids name clashes that otherwise occur when using the same group-by logic in several sub-detectors.
2 tasks
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids name clashes that otherwise occur when using the same group-by logic in several sub-detectors.
--- END COMMIT MESSAGE ---
Missed this in #5193 as up until now I only had different grouping names. Now, I re-use the "grouping label" from several subdetectors and the created volume names would no longer be unique if not prepending the container name.
@paulgessinger