chore: Remove AlignedTelescopeDetector and default-align TelescopeDetector#5369
Merged
kodiakhq[bot] merged 5 commits intoApr 20, 2026
Merged
Conversation
andiwand
changed the title
andiwand
previously approved these changes
Apr 20, 2026
andiwand
left a comment
andiwand
left a comment
Contributor
There was a problem hiding this comment.
Thanks! LGTM 👍
only one minor comment with attached diffs
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
andiwand
previously approved these changes
Apr 20, 2026
andiwand
approved these changes
Apr 20, 2026
Contributor
|
paradajzblond
pushed a commit
to paradajzblond/acts
that referenced
this pull request
Apr 28, 2026
…ector (acts-project#5369) Remove AlignedTelescopeDetector, align TelescopeDetector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove AlignedTelescopeDetector, align TelescopeDetector
--- END COMMIT MESSAGE ---
Follow up to #5256
Removing the
AlignedTelescopeDetectorand the placeholder(?) alignment infrastructure in the TelescopeDetector, and instead adding alignment updates via the geo context directoy to the TelescopeDetector.Update alignment demo to use TelescopeDetector
CC @andiwand