feat: first snapshot of (partly) BinUtility-freed SurfaceMaterial#5521
feat: first snapshot of (partly) BinUtility-freed SurfaceMaterial#5521asalzburger wants to merge 17 commits into
Conversation
github-actions
Bot
added
Component - Core
asalzburger
force-pushed
the
feat-change-material-to-proto-axis
branch
from
909ef79 to
616ad72
Compare
asalzburger
force-pushed
the
feat-change-material-to-proto-axis
branch
from
37c1aae to
d4a816e
Compare
|
| /// @param materialMatrix is the matrix of material slabs (moved) | ||
| /// @param splitFactor is the pre/post splitting directive | ||
| /// @param mappingType is the type of surface mapping associated to the surface | ||
| BinnedSurfaceMaterial(std::array<DirectedProtoAxis, 2> axes, |
There was a problem hiding this comment.
do we strictly need DirectedProtoAxis here? the two things I know of it provides additionally to an IAxis is the direction, which I want to add with #5540, and the auto sizing from ProtoAxis. I imagine this cannot rely on auto sizing since the material matrix is already generated with some given binning.
ultimately we could use IMultiAxisND<N> from here #5531. what do you think?
There was a problem hiding this comment.
Exactly, I think we should use IMultiAxisND<2> here, shall we wait until we are through with the IAxis reordering?
| /// Convert a BinUtility to a pair of two DirectedProtoAxis. | ||
| /// For a 1D BinUtility a single-bin dummy axis is appended as the second axis. | ||
| /// This helper is intended for migration code that still works with BinUtility. | ||
| std::array<DirectedProtoAxis, 2> protoAxesFromBinUtility(const BinUtility& bu); |
There was a problem hiding this comment.
should we elevate this to an utility?
There was a problem hiding this comment.
Yes, actually something that can disappear with the BinUtility.
| #pragma GCC diagnostic push | ||
| #pragma GCC diagnostic ignored "-Wdeprecated-declarations" |
There was a problem hiding this comment.
can we use ACTS_PUSH_IGNORE_DEPRECATED() and ACTS_POP_IGNORE_DEPRECATED for this?
There was a problem hiding this comment.
Oh, let's do this.
| #pragma GCC diagnostic push | ||
| #pragma GCC diagnostic ignored "-Wdeprecated-declarations" |
There was a problem hiding this comment.
can we use ACTS_PUSH_IGNORE_DEPRECATED() and ACTS_POP_IGNORE_DEPRECATED for this?
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
2 participants
This PR makes a first step towards removing BinUtility from the Material classes.
BinnedSurfaceMaterialandProtoSurfaceMaterialare now fully based onDirectedProtoAxis,the legacy constructors with
BinUtilityare marked deprecated and translate the BinUtility into the axis right away.Tests, clients and I/O is updated.
--- END COMMIT MESSAGE ---
Any further description goes here, @-mentions are ok here!
feat,fix,refactor,docs,choreandbuildtypes.