fix: Circumvent symbol visibility issues with templated final classes#5547
Merged
kodiakhq[bot] merged 4 commits intoJun 6, 2026
Conversation
github-actions
Bot
added
Component - Core
Contributor
Contributor
|
Just tested on running GBTS in examples which was originally getting an |
paulgessinger
approved these changes
Jun 6, 2026
Member
|
It's annoying that we have to do this, but oh well. |
|
andiwand
deleted the
fix-circumvent-symbol-visibility-template-final-class
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discovered with #5536 there seems to be a general risk of using
template class finalwhich makesdynamic_castfail across shared library boundaries. The easiest path to circumvent the problem right now appears to be droppingfinalfrom the class and making the functions final instead which results almost in the same behavior.--- END COMMIT MESSAGE ---
References
dynamic_caston Apple platforms. llvm/llvm-project#120129