fix: skip material-merge clash check for single-child stacks#5576
Merged
kodiakhq[bot] merged 3 commits intoJun 12, 2026
Conversation
The early material-clash pre-check in ContainerBlueprintNode::connectImpl
iterated over ShellStack::mergedFaces() for every shell regardless of how
many children were present. For an AxisZ stack that returns
{OuterCylinder, InnerCylinder}, which are only actually merged when two or
more children are stacked. With a single child no portal merge takes place,
so flagging material on those faces was a false positive that caused a
spurious warning (or, in strict mode, a throw).
Fix: guard the merged-face loop with shells.size() > 1 so the check is
skipped entirely when there is nothing to merge.
Contributor
andiwand
approved these changes
Jun 12, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The early material-clash pre-check in ContainerBlueprintNode::connectImpl iterated over ShellStack::mergedFaces() for every shell regardless of how many children were present. For an AxisZ stack that returns {OuterCylinder, InnerCylinder}, which are only actually merged when two or more children are stacked. With a single child no portal merge takes place, so flagging material on those faces was a false positive that caused a spurious warning (or, in strict mode, a throw).
Fix: guard the merged-face loop with shells.size() > 1 so the check is skipped entirely when there is nothing to merge.
--- END COMMIT MESSAGE ---