Skip to content

ref: update random scatter only when material is non-zero #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented Apr 2, 2025

Update the track momentum and trigger re-navigation only when the surface has material with non-zero thickness.

@niermann999 niermann999 force-pushed the fix-sim branch 3 times, most recently from 8f617c8 to 3bf3721 Compare April 3, 2025 09:51
@beomki-yeo
Copy link
Collaborator

I suggest to make a general aborter, which includes constraints on path and particle momentum, instead of editing random_scatterer

@niermann999 niermann999 changed the title ref: stop fast sim for very low momentum particles ref: update random scatter only when material is present Apr 8, 2025
@niermann999 niermann999 changed the title ref: update random scatter only when material is present ref: update random scatter only when material is non-zero Apr 8, 2025
@niermann999 niermann999 force-pushed the fix-sim branch 2 times, most recently from 71d1f69 to b19e8dd Compare April 9, 2025 07:08
@niermann999
Copy link
Contributor Author

I suggest to make a general aborter, which includes constraints on path and particle momentum, instead of editing random_scatterer

Agreed, done in #969

Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple and sensible.

@niermann999 niermann999 merged commit e8d0998 into acts-project:main Apr 28, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants