feat: Add some extra assertions #971
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
force-pushed
the
feat-more-assertions
branch
6 times, most recently
from
072c8a5 to
f0d764d
Compare
niermann999
force-pushed
the
feat-more-assertions
branch
5 times, most recently
from
cb20bc7 to
18494c2
Compare
niermann999
force-pushed
the
feat-more-assertions
branch
2 times, most recently
from
02137cf to
dc2b539
Compare
niermann999
force-pushed
the
feat-more-assertions
branch
11 times, most recently
from
39ef59c to
1b711cd
Compare
niermann999
force-pushed
the
feat-more-assertions
branch
9 times, most recently
from
0b3ab95 to
6ab4aae
Compare
niermann999
force-pushed
the
feat-more-assertions
branch
from
6ab4aae to
0f2d13f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some assertions for the next candidate index and make sure the track parameters are valid. The latter will catch the segfault in traccc issue #913. Also tries to catch potential divisions by zero in the stepper and catch invalid surface/volume descriptors early. This lead to some minor followup corrections in the tests