feat: abort messages #979
Merged
feat: abort messages #979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
force-pushed
the
feat-abort-messages
branch
2 times, most recently
from
0d23be8 to
4c54781
Compare
niermann999
force-pushed
the
feat-abort-messages
branch
6 times, most recently
from
9199348 to
3b54d7d
Compare
niermann999
force-pushed
the
feat-abort-messages
branch
2 times, most recently
from
9199348 to
7ad3756
Compare
This comment was marked as outdated.
This comment was marked as outdated.
niermann999
force-pushed
the
feat-abort-messages
branch
2 times, most recently
from
800d0e7 to
dd11e06
Compare
niermann999
force-pushed
the
feat-abort-messages
branch
2 times, most recently
from
329838e to
c5c90bc
Compare
stephenswat
reviewed
Apr 28, 2025
Comment on lines
231
to
235
| template <typename G> | ||
| DETRAY_HOST_DEVICE inline auto abort(const G &) -> bool { | ||
| return abort(); | ||
| } |
There was a problem hiding this comment.
What G supposed to be here?
There was a problem hiding this comment.
This is the call interface impl corresponding to the call containing the functor debug_msg_generator_t in the navigator. So it stands for "generator" I guess, but I can spell it out
niermann999
force-pushed
the
feat-abort-messages
branch
from
c5c90bc to
4f20e69
Compare
niermann999
force-pushed
the
feat-abort-messages
branch
from
4f20e69 to
2c6e4db
Compare
|
stephenswat
approved these changes
Apr 29, 2025
Maybe I am just confused by what you mean. But lets for now move ahead with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to pass additional messages to the navigator abort function that contain the reason for the failure. This will make it easier to debug, because it can be seen right away from where
abortwas called and why. The reason for the error is also preserved in the print inspector, which makes it easier to print it to the user in tests outside the debug file.