Skip to content

Comments

Fix use of uninitialized track parameters#1252

Merged
stephenswat merged 1 commit intoacts-project:mainfrom
stephenswat:fix/track_param_uninit
Feb 9, 2026
Merged

Fix use of uninitialized track parameters#1252
stephenswat merged 1 commit intoacts-project:mainfrom
stephenswat:fix/track_param_uninit

Conversation

@stephenswat
Copy link
Member

The track parameter estimation kernel currently uses unitialized track parameters. This commit fixes this issue by explicitly initializing the objects after allocation.

@stephenswat stephenswat added the bug Something isn't working label Feb 5, 2026
@stephenswat
Copy link
Member Author

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298341 to 298344 (+0.0%)

Seeding plots



Track finding performance

Total number of found tracks went from 50265 to 50264 (-0.0%)

Finding plots









Track fitting performance

Fitting plots














Seeding to track finding relative performance

Seeding to track finding plots



Note

This is an automated message produced on the explicit request of a human being.

The track parameter estimation kernel currently uses unitialized track
parameters. This commit fixes this issue by explicitly initializing the
objects after allocation.
@stephenswat stephenswat force-pushed the fix/track_param_uninit branch from 3e7570c to faa7d53 Compare February 9, 2026 08:53
@stephenswat stephenswat enabled auto-merge February 9, 2026 08:53
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2026

@stephenswat stephenswat merged commit 93f33f2 into acts-project:main Feb 9, 2026
32 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants