Refactor subspace storage and handling#1308
Open
stephenswat wants to merge 1 commit into
Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This commit refactors the subspace representation to become more compact, and also adds additional member functions to elegantly model some of the operations performed on the projection matrix in the Kálmán filter code. Specifically, it packs the indices using a single bit field rather than an array of integers. Furthermore, it allows for the subspace to store signed projections (used for line surfaces) as well as invalid projections (used for 1D measurements).
356c4a3 to
0b7bb10
Compare
|
niermann999
approved these changes
May 7, 2026
Member
Author
Physics performance summaryHere is a summary of the physics performance effects of this PR. Command used: Seeding performanceTotal number of seeds went from 298341 to 298340 (-0.0%) Track finding performanceTotal number of found tracks went from 50211 to 50206 (-0.0%) Track fitting performanceSeeding to track finding relative performanceNote This is an automated message produced on the explicit request of a human being. |
Member
Author
Performance summaryHere is a summary of the performance effects of this PR: GraphicalTabular
Important All metrics in this report are given as reciprocal throughput, not as wallclock runtime. Warning At least one kernel incurred a significant performance regression. Note This is an automated message produced upon the explicit request of a human being. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

































This commit refactors the subspace representation to become more compact, and also adds additional member functions to elegantly model some of the operations performed on the projection matrix in the Kálmán filter code. Specifically, it packs the indices using a single bit field rather than an array of integers. Furthermore, it allows for the subspace to store signed projections (used for line surfaces) as well as invalid projections (used for 1D measurements).