Skip to content

Update ACTS to version 46.5.0 and use its detray#1327

Open
stephenswat wants to merge 1 commit into
acts-project:mainfrom
stephenswat:build/acts_46_5_0
Open

Update ACTS to version 46.5.0 and use its detray#1327
stephenswat wants to merge 1 commit into
acts-project:mainfrom
stephenswat:build/acts_46_5_0

Conversation

@stephenswat
Copy link
Copy Markdown
Member

This commit updates our ACTS dependency to version 46.5.0. It also removes our own external detray mechanisms and relies almost entirely on ACTS to provide detray. Until ACTS directly exposes the detray targets, we still need to FetchContent the detray content from the ACTS repository. Also automatically adds the ITk detector metadata if it is not provided.

@stephenswat stephenswat requested a review from niermann999 May 13, 2026 13:47
@stephenswat stephenswat added the build This relates to the build system label May 13, 2026
@stephenswat stephenswat force-pushed the build/acts_46_5_0 branch 5 times, most recently from f9f8115 to 05593ea Compare May 13, 2026 15:12
@stephenswat
Copy link
Copy Markdown
Member Author

stephenswat commented May 14, 2026

Copy link
Copy Markdown
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 2 options to move forward:

  • We first make some changes in Acts. Currently it is just way too hostile towards the setup that we would need from it.
  • We keep the fundamental setup in this repository as it's always been.
    • We keep extern/acts building just Acts;
    • We make extern/detray download the Acts TGZ, and build Detray out of that. (Using a SOURCE_SUBDIR argument to the existing FetchContent call. So that it would pick up just Detray out of the Acts source tree.)

Clearly N.1 is the better choice. But it's also what will take longer.

@stephenswat
Copy link
Copy Markdown
Member Author

  • We make extern/detray download the Acts TGZ, and build Detray out of that. (Using a SOURCE_SUBDIR argument to the existing FetchContent call. So that it would pick up just Detray out of the Acts source tree.)

Explain to me how this is any better than the current approach.

@niermann999
Copy link
Copy Markdown
Contributor

Should be fixed here https://github.com/acts-project/acts/pull/5452/changes

This commit updates our ACTS dependency to version 46.5.0. It also
removes our own external detray mechanisms and relies almost entirely on
ACTS to provide detray. Until ACTS directly exposes the detray targets,
we still need to FetchContent the detray content from the ACTS
repository. Also automatically adds the ITk detector metadata if it is
not provided.
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build This relates to the build system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants