make sycl measurement sorting algo interface match cuda's #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasznaa
requested changes
May 2, 2025
| @@ -21,6 +21,10 @@ | |||
| // System include(s). | |||
| #include <functional> | |||
|
|
|||
| namespace traccc { | |||
| struct memory_resource; | |||
There was a problem hiding this comment.
No need to be too clever here. Let's just include the appropriate header for this type.
krasznaa
force-pushed
the
sycl_ms_intf_consistency
branch
from
f20d106 to
a37d39a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure it's worth it but I'll let traccc folks decide, since it was suggested by @krasznaa. It would save G-200 one template specialization: great success :)