[WIP] Redirect the user to the budget page regardless of accounts

[PratikSilwal5]

Fixes #6977

The issue is that we are checking explicitly for this condition. So, if users don't have accounts setup, which is true when they are creating a fresh budget, we redirect them to "all accounts" to prompt them to create new accounts. Based on the issue, I think we can remove this check to redirect them to the budget page.

https://github.com/actualbudget/actual/blob/master/packages/desktop-client/src/components/FinancesApp.tsx#L248-L260

---

Bundle Stats

Bundle	Files count	Total bundle size	% Changed
desktop-client	28	14.78 MB → 14.78 MB (-172 B)	-0.00%
loot-core	1	5.86 MB	0%
api	1	4.4 MB	0%

View detailed bundle stats

desktop-client

Total

Files count	Total bundle size	% Changed
28	14.78 MB → 14.78 MB (-172 B)	-0.00%

Changeset

File	Δ	Size
src/components/FinancesApp.tsx	📉 -172 B (-0.90%)	18.59 kB → 18.42 kB

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller

Asset	File Size	% Changed
static/js/index.js	9.52 MB → 9.51 MB (-172 B)	-0.00%

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	12.94 kB	0%
static/js/workbox-window.prod.es5.js	5.64 kB	0%
static/js/ca.js	96.92 kB	0%
static/js/da.js	106.62 kB	0%
static/js/de.js	180.44 kB	0%
static/js/en-GB.js	7.18 kB	0%
static/js/en.js	165.58 kB	0%
static/js/es.js	173.83 kB	0%
static/js/fr.js	179.97 kB	0%
static/js/it.js	171.44 kB	0%
static/js/nb-NO.js	157.23 kB	0%
static/js/nl.js	106.65 kB	0%
static/js/pl.js	88.64 kB	0%
static/js/pt-BR.js	154.57 kB	0%
static/js/sv.js	78.2 kB	0%
static/js/th.js	182.35 kB	0%
static/js/uk.js	215.11 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	120.54 kB	0%
static/js/ReportRouter.js	1.13 MB	0%
static/js/narrow.js	638.75 kB	0%
static/js/TransactionList.js	106.13 kB	0%
static/js/wide.js	165.25 kB	0%
static/js/AppliedFilters.js	9.71 kB	0%
static/js/usePayeeRuleCounts.js	10.05 kB	0%
static/js/useTransactionBatchActions.js	13.23 kB	0%
static/js/FormulaEditor.js	1.04 MB	0%

---

loot-core

Total

Files count	Total bundle size	% Changed
1	5.86 MB	0%

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.92NpqIpU.js	5.86 MB	0%

---

api

Total

Files count	Total bundle size	% Changed
1	4.4 MB	0%

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
bundle.api.js	4.4 MB	0%

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	359d03b
🔍 Latest deploy log	https://app.netlify.com/projects/actualbudget/deploys/69914c041683bb00080cc7c3
😎 Deploy Preview	https://deploy-preview-6978.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[github-actions]

👋 Hello contributor!

We would love to review your PR! Before we can do that, please make sure:

• ✅ All CI checks pass
• ✅ The PR is moved from draft to open (if applicable)
• ✅ The "[WIP]" prefix is removed from the PR title
• ✅ All CodeRabbit code review comments are resolved (if you disagree with anything - reply to the bot with your reasoning so we can read through it). The bot will eventually approve the PR.

We do this to reduce the TOIL the core contributor team has to go through for each PR and to allow for speedy reviews and merges.

For more information, please see our Contributing Guide.

[netlify]

✅ Deploy Preview for actualbudget-website ready!

Name	Link
🔨 Latest commit	3874f49
🔍 Latest deploy log	https://app.netlify.com/projects/actualbudget-website/deploys/69912945968aa900084359b3
😎 Deploy Preview	https://deploy-preview-6978.www.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[netlify]

✅ Deploy Preview for actualbudget-storybook ready!

Name	Link
🔨 Latest commit	3874f49
🔍 Latest deploy log	https://app.netlify.com/projects/actualbudget-storybook/deploys/69912945c79ad00008044b25
😎 Deploy Preview	https://deploy-preview-6978--actualbudget-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

📝 Walkthrough

Walkthrough

The root-route navigation logic in FinancesApp was simplified to always redirect to the budget page after accounts finish loading, removing the conditional redirect based on account count. A release notes entry documents this bug fix.

Changes

Cohort / File(s)	Summary
Root Route Navigation packages/desktop-client/src/components/FinancesApp.tsx	Simplified routing logic to always navigate to /budget once accounts are loaded, eliminating the conditional redirect to /accounts based on account count.
Release Notes upcoming-release-notes/6978.md	Added release notes entry documenting the bug fix for consistently redirecting to the budget page on app load.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 The budget page was lost in the code,
A simple fix puts us back on the road,
Always to budget, no more detours today,
The finances flow in the proper way! 💰✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is directly related to the changeset, explaining the issue #6977 and the specific conditional check being removed in FinancesApp.tsx.
Linked Issues check	✅ Passed	The pull request successfully addresses issue #6977 by removing the conditional redirect that forced users without accounts to the accounts page, ensuring the app navigates to the budget page as intended.
Out of Scope Changes check	✅ Passed	All changes are directly related to issue #6977: simplifying root-route logic in FinancesApp.tsx and adding a release note, with no out-of-scope modifications.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into master
Title check	✅ Passed	The title clearly and specifically describes the main change: redirecting users to the budget page regardless of account status, which directly matches the core modification in FinancesApp.tsx.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🤖 Auto-generated Release Notes

Hey @PratikSilwal5! I've automatically created a release notes file based on CodeRabbit's analysis:

Category: Features
Summary: Redirect users to the budget page regardless of their account status.
File: upcoming-release-notes/6978.md

If you're happy with this release note, you can add it to your pull request. If not, you'll need to add your own before a maintainer can review your change.

[PratikSilwal5]

/update-vrt

[PratikSilwal5]

/update-vrt

[github-actions]

VRT tests ❌ failed. View the test report.

To update the VRT screenshots, comment /update-vrt on this PR. The VRT update operation takes about 50 minutes.

[PratikSilwal5]

/update-vrt