Implement more GSP features #2532
Conversation
| ad_utility::triple_component::Iri GraphStoreProtocol::generateGraphIri() { | ||
| ad_utility::SlowRandomIntGenerator<uint64_t> randGraphIriSuffix_; | ||
| return ad_utility::triple_component::Iri::fromIriref( | ||
| QLEVER_NEW_GRAPH_PREFIX + std::to_string(randGraphIriSuffix_()) + ">"); | ||
| } |
There was a problem hiding this comment.
Note: this might (though probably more in theory than in practice) generate the same graph twice making it incorrect. Keeping tracks of all graphs and/or explicit graph existence would go beyond the scope of this PR. As an intermediate solution the graphs will be generated with the internal prefix and a counter.
| // For a `POST` when the graph identifies the QLever instance itself then | ||
| // the data must be stored in a newly generated graph which is returned in | ||
| // the response. | ||
| // TODO: test this with jena |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2532 +/- ##
==========================================
- Coverage 91.52% 91.35% -0.18%
==========================================
Files 479 482 +3
Lines 41177 41338 +161
Branches 5474 5492 +18
==========================================
+ Hits 37688 37763 +75
- Misses 1910 1987 +77
- Partials 1579 1588 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
# Conflicts: # src/engine/CMakeLists.txt # src/engine/Server.cpp
Overview
Conformance check failed ❌Test Status Changes 📊
|
|
1 participant
HEADoperation. Closes ad-freiburg/qlever-private#63PUT. Closes ad-freiburg/qlever-private#61POSTwhere the server creates a new graph. Note: the chosen graph is not guaranteed to not exist before. An intermediate solution could be to generate the graphs with a prefix and a counter. Knowing which graphs exist is a more involved task. Closes ad-freiburg/qlever-private#75Open questions: