-
Notifications
You must be signed in to change notification settings - Fork 107
Fix the exceptions more cleanly in the CallbackOnEndView, #2533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix the exceptions more cleanly in the CallbackOnEndView, #2533
Conversation
but there still seem to be issues with pfpfs queries. Signed-off-by: Johannes Kalmbach <[email protected]>
Overview
Conformance check passed ✅No test result changes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2533 +/- ##
==========================================
+ Coverage 91.11% 91.12% +0.01%
==========================================
Files 466 466
Lines 39777 39801 +24
Branches 5320 5316 -4
==========================================
+ Hits 36242 36270 +28
+ Misses 2024 2021 -3
+ Partials 1511 1510 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
I also see termination on queries that don't have an enclosing COUNT piece. One of these terminates very quickly. Here is the server log of the terminations, both with and without COUNT. This is using the most recent Wikidata RDF dump and the most recent version of QLever with the same server options as before. |




but there still seem to be issues with pfpfs queries.