Make it possible to load no permutations at all #2587
Conversation
Signed-off-by: Johannes Kalmbach <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2587 +/- ##
==========================================
+ Coverage 91.52% 91.54% +0.01%
==========================================
Files 479 479
Lines 41177 41197 +20
Branches 5474 5482 +8
==========================================
+ Hits 37688 37714 +26
+ Misses 1910 1904 -6
Partials 1579 1579 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Johannes Kalmbach <[email protected]>
|
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
# Conflicts: # src/libqlever/Qlever.h
Signed-off-by: Johannes Kalmbach <[email protected]>
| load(sop_); | ||
| } else { | ||
| if (dontLoadPermutations_) { | ||
| // Set all permutations to nullptr to indicate they are not loaded. |
There was a problem hiding this comment.
With this change, the term "loaded" becomes ambiguous. There already is Permutation::isLoaded. Can't you use that instead and just prevent the reading from disk part?
There was a problem hiding this comment.
Unfortunately this doesn't work, as this function is also called during the index building when the permutation is not yet loaded.
I agree that this is unfortunate, but for now I will leave this.
Signed-off-by: Johannes Kalmbach <[email protected]>
Overview
Conformance check passed ✅No test result changes. |
|
3 participants
Add an options to libqlever to load an index without its permutations.
This index can still be used to answer queries that don't depend on the permutations (i.e. don't contain any triples), because they for example rely on the named query cache.
This allows for efficient scenarios where all queries can be answered from the named query cache, so the files from the permutations don't even have to be present.