optimize canonicalize methods for url_pattern #1033
Conversation
CodSpeed Performance ReportMerging #1033 will degrade performances by 99.99%Comparing Summary
Benchmarks breakdown
Footnotes
|
anonrig
force-pushed
the
yagiz/optimize-canonicalize-methods
branch
from
792e6ed to
5da3603
Compare
|
@lemire can you review? |
CarlosEduR
left a comment
CarlosEduR
left a comment
There was a problem hiding this comment.
Looks good to me, but I'd still like Daniel to take a look.
| if (!url->set_username(input)) { | ||
| return tl::unexpected(errors::type_error); | ||
| // Percent-encode the input using the userinfo percent-encode set. | ||
| size_t idx = ada::unicode::percent_encode_index( |
|
|
||
| if (result.ec == std::errc()) { | ||
| // Successfully parsed, return as string | ||
| return std::to_string(parsed_port); |
There was a problem hiding this comment.
Presumably, this could be avoided by using the range digits_to_parse.data() to digits_to_parse.data() + digits_to_parse.size() as it should be a valid number string. Although it might be not necessary.
The whole logic here is to ensure that we have a 16-bit unsigned string. This could be better.
Still: this is fine.
There was a problem hiding this comment.
Ah nice touch. Agreed. Let's fix it! I'll open a PR
This would significantly improve URLPattern performance