Skip to content

Codspeed: fix WPT benchmark #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anonrig merged 3 commits into from
Dec 11, 2025
Merged

Codspeed: fix WPT benchmark #1038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7dd1f0e
codspeed: fix WPT benchmark
CarlosEduR Dec 10, 2025
6f6a030
Merge branch 'main' of https://github.com/CarlosEduR/ada into fix-cod…
CarlosEduR Dec 11, 2025
fd08ef6
fix merge conflict
CarlosEduR Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions benchmarks/benchmark_template.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ size_t count_whatwg_invalid() {
}

template <bool just_parse = false>
static void BasicBench_whatwg(benchmark::State& state) {
static void BENCHMARK_NAME(BasicBench_whatwg)(benchmark::State& state) {
// volatile to prevent optimizations.
volatile size_t success = 0;
volatile size_t href_size = 0;
Expand Down Expand Up @@ -248,7 +248,10 @@ static void BasicBench_whatwg(benchmark::State& state) {
state.counters["url/s"] = benchmark::Counter(
std::size(url_examples), benchmark::Counter::kIsIterationInvariantRate);
}
BENCHMARK(BasicBench_whatwg);
static auto* CONCAT(benchmark_register_, BENCHMARK_NAME(BasicBench_whatwg)) =
::benchmark::RegisterBenchmark(BENCHMARK_PREFIX_STR "BasicBench_whatwg",
BENCHMARK_NAME(BasicBench_whatwg));

// There is no need for BasicBench_whatwg_just_parse because whatwg appears to
// provide the href at a minimal cost, probably because it is already
// materialized. auto BasicBench_whatwg_just_parse =
Expand Down
13 changes: 7 additions & 6 deletions benchmarks/wpt_bench.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,16 +144,17 @@ static void BasicBench_AdaURL(benchmark::State &state) {
benchmark::Counter(double(std::size(url_examples)),
benchmark::Counter::kIsIterationInvariantRate);
}
auto BasicBench_AdaURL_url = BasicBench_AdaURL<ada::url>;
BENCHMARK(BasicBench_AdaURL_url);
auto BasicBench_AdaURL_url_aggregator = BasicBench_AdaURL<ada::url_aggregator>;
BENCHMARK(BasicBench_AdaURL_url_aggregator);
auto WptBench_BasicBench_AdaURL_url = BasicBench_AdaURL<ada::url>;
BENCHMARK(WptBench_BasicBench_AdaURL_url);
auto WptBench_BasicBench_AdaURL_url_aggregator =
BasicBench_AdaURL<ada::url_aggregator>;
BENCHMARK(WptBench_BasicBench_AdaURL_url_aggregator);

#if ADA_url_whatwg_ENABLED

#include <upa/url.h>

static void BasicBench_whatwg(benchmark::State &state) {
static void WptBench_BasicBench_whatwg(benchmark::State &state) {
volatile size_t success{};
for (auto _ : state) {
for (const std::pair<std::string, std::string> &url_strings :
Expand Down Expand Up @@ -224,7 +225,7 @@ static void BasicBench_whatwg(benchmark::State &state) {
benchmark::Counter(double(std::size(url_examples)),
benchmark::Counter::kIsIterationInvariantRate);
}
BENCHMARK(BasicBench_whatwg);
BENCHMARK(WptBench_BasicBench_whatwg);
#endif // ADA_url_whatwg_ENABLED

int main(int argc, char **argv) {
Expand Down
Loading