[url_patter] Avoid parsing the port #1039
Merged
+16
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the final step of the function, we merely validate that it is a port number. But this does not work require parsing the port. E.g., any port string with 3 or 4 characters (like 8001) is obviously valid as long as it does not start with 0.
anonrig
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this function, we parse the 16-bit port, only to convert it back to a string. That looks inefficient.
If we don't need the port number, we can be faster.
I asked grok to verify my code, here was the answer:
https://x.com/lemire/status/1999223408605774179?s=20