Skip to content

Conversation

@lemire
Copy link
Member

@lemire lemire commented Apr 23, 2025

fixes #939

@lemire lemire requested review from anonrig and Copilot April 23, 2025 21:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for pkg-config by introducing a new GitHub Actions workflow for building, installing, and testing Debian packages.

  • Introduces a new workflow (.github/workflows/pkg.yml) that runs on push and pull_request events.
  • Configures the job to run inside a Debian container and executes build, install, and pkg-config test steps.
Files not reviewed (2)
  • CMakeLists.txt: Language not supported
  • cmake/JoinPaths.cmake: Language not supported

@lemire
Copy link
Member Author

lemire commented Apr 23, 2025

@aduh95 @anonrig

I named the pkg ada-url but this can be changed to ada. I am mildly concerned that ada could be too generic in this context.

@aduh95
Copy link

aduh95 commented Apr 23, 2025

I named the pkg ada-url but this can be changed to ada. I am mildly concerned that ada could be too generic in this context.

Shouldn't we name it to ada and give instructions on how to change the name if it conflicts? For my use-case, it's not going to conflict and it's slightly annoying to have to patch the name

@lemire
Copy link
Member Author

lemire commented Apr 23, 2025

I switched the name to 'ada'.

Co-authored-by: Antoine du Hamel <[email protected]>
image: debian:12

steps:
- uses: actions/checkout@v3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW v4 is available

@anonrig anonrig merged commit 301b052 into main Apr 24, 2025
40 checks passed
@anonrig anonrig deleted the pkg branch April 24, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for pkgconfig

4 participants