Added support for 8mm Soft Tactile Switches #39
+60
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Tactile Switches, Adafruit product id 3101. Tested with sample PCB for fitment. modified: adafruit.lbr
|
I think your symbol is off. The symbol is named TS-1 but you reference TS2 in the device. Just FYI. |
|
@flyandi thank you, I must have missed that. I'll double check it later today and fix it. |
|
Hmm. When I clone my branch I have 2 SPST_TACT devices. One is the SPST_TACT-8 for the 8mm and one is SPST_TACT for the 6mm. Both use the TS2 (could probably be named "TS-2" to maintain convention with "TS-1") because they have 2 pads that are internally connected on each side of the switch. I don't see a reference to TS-1 in either of those devices. |
Yutao-Jin
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added package TACT-8-THMD and device SPST_TACT-8 to support 8mm Soft Tactile Button, Adafruit product id 3101 (https://www.adafruit.com/product/3101). Tested with a manufactured PCB for fitment.
SPST_TACT-8 could be merged as a variant of SPST_TACT with existing packages and devices renamed if that is preferable.