-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add animations examples #9
base: main
Are you sure you want to change the base?
Conversation
Sorry, I forgot to initialize pre-commit. I will do that and fix the trailing whitespace error. |
Hi! Thanks for the submission. Is this ready for review? |
If you like what I've done so far, my plan was to include similar code samples and explanations for the remaining LED animation functions. Would you like me to add the other LED animation functions to the documentation? |
Sure! Just say whenever its ready - I just wanted to make sure it wasn't accidentally marked as draft and therefore accidentally ignored. |
My recommendation would be to add your code, comments, and documentation as working Python files in the |
Sounds good. I can do that. Also, I'll be testing it on a Feather Scorpio
and that way, I can attest to the code. If I have the time, I might also
record short videos/gifs of the code in action on my neopixel strands and
include them in the rst files.
…On Sun, Jul 30, 2023 at 7:25 PM Alec Delaney ***@***.***> wrote:
My recommendation would be to add your code, comments, and documentation
as working Python files in the examples/ folder so that people can
readily add them to their device. Having working examples files they can
immediately use and begin tweaking will help them better understand the
functionalities.
—
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5GKUSAMIVUP4KJUTEZXGTXS4JQTANCNFSM6AAAAAA2SDCEJQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
NOTE: this pull request is in draft state, so you can provide any feedback before I add any more documentation.
So far, I've added two additional sections to
examples.rst
:examples/neopxl8_simpletest.py
file code andFor the LED Animations Functions section, I've included the first two of twelve so you can see what I'm thinking of doing for each function. My thought is to include the following for each animation function:
Please let me know if you have any questions or concerns with the path I'm taking.