ThinkInk_213_Grayscale4_MFGN: add optional colstart#97
Open
mikeysklar wants to merge 2 commits into
Open
Conversation
mikeysklar
changed the title
Exposes the panel's left RAM-X offset via an optional `colstart` constructor argument (pixels, default 0), so the 8px offset some 2.13" SSD1680 panels need can be set from the sketch instead of editing _xram_offset in library source. Default 0 preserves current behavior (no change for existing users). Pass colstart=8 for the FPC-7528B revision of the 2.13" breakout, which otherwise shows an 8px unwritten strip on the left edge. Verified on a Feather RP2350. Refs the workaround in adafruit#77 ("you need to set _xram_offset = 0"). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mikeysklar
force-pushed
the
colstart-param-mfgn
branch
from
613c4f0 to
50a3da2
Compare
Comment only at the MFGN panel line pointing out that some 2.13" SSD1680 revisions (e.g. FPC-7528B) need a trailing colstart=8 argument. No behavior change to the example. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mikeysklar
force-pushed
the
colstart-param-mfgn
branch
from
0123b2d to
ae7a467
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
colstartparameter toThinkInk_213_Grayscale4_MFGNallows user settable offset for SSD1680 panels. Default colstart will be set to 0 (same as existing behavior) some panels need to use 8.Tested