Fix NVM example on ESP8266 - #3
Merged
ladyada merged 1 commit intoJul 21, 2026
Merged
Conversation
ladyada-eagleclaw
force-pushed
the
fix-wire-end-portability
branch
from
July 21, 2026 14:10
a5b4c39 to
58ca281
Compare
Co-authored-by: Limor Fried <ladyada@users.noreply.github.com>
ladyada-eagleclaw
force-pushed
the
fix-wire-end-portability
branch
from
July 21, 2026 14:21
58ca281 to
6c7cf4c
Compare
ladyada
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CI failure caused by ESP8266 TwoWire not implementing end(). Guards Wire.end() with the standard WIRE_HAS_END feature macro and updates the matching hardware test and README guidance.\n\nVerified locally and independently by Terra:\n- ESP8266 Huzzah, core 3.1.2: nvm_persistence passes\n- Arduino Uno, AVR core 1.8.8: 03_nvm_persistence passes