Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct a comment about overriding the SD_VERSION in CMakeLists.txt #348

Closed
wants to merge 1 commit into from

Conversation

obra
Copy link

@obra obra commented Mar 2, 2025

All existing boards that override SD_VERSION do it in board.mk and, at least, my naive attempt to do it in board.cmake didn't actually work.

Checklist

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

  • Please provide specific title of the PR describing the change

This checklist items that are not applicable to your PR can be deleted.


Description of Change

A doc change to help folks getting started with softdevice version customization.

All existing boards that override SD_VERSION do it in board.mk and, at least, my naive attempt to do it in board.cmake didn't actually work.
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment is correct though if you use

  • cmake you change the board.cmake
  • make you change the board.mk

These are 2 different bulid system. FYI, This repo started with make as official buildsystem, then I slowly add cmake as additional build system.

@obra
Copy link
Author

obra commented Mar 3, 2025

Oh! I'm so sorry. I'd assumed that the make based build system was using the cmake build system under the covers, since the make targets were the ones docced in the README. I'll close this out.

@obra obra closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants