Skip to content

Add ability to set halt state on DS1307 #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ability to set halt state on DS1307 #292

wants to merge 1 commit into from

Conversation

@AmirHmZz
Copy link

@AmirHmZz AmirHmZz commented Oct 13, 2023

This PR adds ability to change halt state on DS1307 using halt() method.

@edgar-bonet
Copy link
Contributor

edgar-bonet commented Oct 13, 2023

I noticed this PR has a failed check. It is clang-format complaining that RTC_DS1307::halt() does not follow the standard indentation style of this library, which is two spaces per level. You may fix it by hand or run:

clang-format -i src/RTC_DS1307.cpp

@AmirHmZz
Copy link
Author

AmirHmZz commented Oct 13, 2023

@edgar-bonet Thank you. I've fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AmirHmZz @edgar-bonet