fix copy constructor backward compatible for libraries such as Adafruit_WavePlayer #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d compatible for libraries such as Adafruit_WavePlayer
Member
|
thanks please do a release bump and thn we'll see if that fixes the compilation |
Member
Author
|
yeah, already bump a new release, but there is still another issue with other board, checking it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FILE_COPY_CONSTRUCTOR_SELECT=FILE_COPY_CONSTRUCTOR_PUBLIC for backward compatible for libraries such as Adafruit_WavePlayer, which is default to private starting from https://github.com/greiman/SdFat/releases/tag/2.2.3
this fix wave player in learning guide demo build e.g https://github.com/adafruit/Adafruit_Learning_System_Guides/actions/runs/15434059172/job/43436985380#step:7:616
@ladyada