Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mpconfigboard.mk #10143

Closed
wants to merge 3 commits into from
Closed

Update mpconfigboard.mk #10143

wants to merge 3 commits into from

Conversation

cmarxmeier
Copy link

removed rmf9x from frozen - heltec v3 uses sx1262 Lora-chipset

@cmarxmeier
Update mpconfigboard.mk
de399f3 
removed rmf9x from frozen - heltec v3 uses sx1262 Lora-chipset
tannewt
tannewt requested changes Mar 19, 2025
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Please just delete it. The git history will show the reasoning.

dhalbert
dhalbert requested changes Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this change against the 9.2.x branch, which we just created, instead of main. You may be able just to select the "EDIT" button to the right of the PR title and change the base in the dropdown.

@cmarxmeier
Merge branch 'adafruit:main' into main
b83da89
@cmarxmeier
Update mpconfigboard.mk
e0fe3e7 
remove rfm9x from frozen for heltec v3 - devices uses sx1262 Lora-Chipset
@cmarxmeier
Copy link
Author

submitted #10146 for 9.2.x tree

@cmarxmeier cmarxmeier closed this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt requested changes

@dhalbert dhalbert dhalbert requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmarxmeier @tannewt @dhalbert