Skip to content

Array in where#125

Open
gueno-dev wants to merge 1 commit into
adam-cowley:masterfrom
gueno-dev:array-in-where
Open

Array in where#125
gueno-dev wants to merge 1 commit into
adam-cowley:masterfrom
gueno-dev:array-in-where

Conversation

@gueno-dev
Copy link
Copy Markdown
Contributor

Hello, actually we can't do that :

nodes = await instance.all('Label', { id: [1, 2, 3] });

because the '=' operator is set by default there :

args = [args[0], _Where.OPERATOR_EQUALS, args[1]];

I have just added type control of the second argument to use IN operator in this case.

Thanks !

Copy link
Copy Markdown

@kaeross kaeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, it would be good to add a test for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants