Skip to content

Swift settings, clean up storage protocols#16

Merged
adam-fowler merged 4 commits into
mainfrom
span
Jun 3, 2026
Merged

Swift settings, clean up storage protocols#16
adam-fowler merged 4 commits into
mainfrom
span

Conversation

@adam-fowler

Copy link
Copy Markdown
Owner
  • Swift settings ExistentialAny, InternalImportsByDefault, MemberImportVisibility
  • Only require RangeReplaceableCollection on Bytes for MemoryBuffer writing functions
  • Only conform ZipMemoryStorage to ZipWriteableStorage in Bytes conforms to RangeReplaceableCollection
  • Break out ZipReadableStorage and ZipWriteableStorage into separate files

@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.38889% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.71%. Comparing base (ea58333) to head (570ebdf).

Files with missing lines Patch % Lines
Sources/ZipArchive/ZipReadableStorage.swift 69.23% 8 Missing ⚠️
Sources/ZipArchive/MemoryBuffer.swift 76.19% 5 Missing ⚠️
Sources/ZipArchive/ZipWriteableStorage.swift 75.00% 3 Missing ⚠️
Sources/ZipArchive/ZipMemoryStorage.swift 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   86.04%   85.71%   -0.33%     
==========================================
  Files          15       17       +2     
  Lines        1225     1225              
==========================================
- Hits         1054     1050       -4     
- Misses        171      175       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adam-fowler
adam-fowler merged commit adc5563 into main Jun 3, 2026
14 of 17 checks passed
@adam-fowler
adam-fowler deleted the span branch June 3, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant