fix(pseudohome): bound clone SSH timeout, add run() heartbeat - #91
Merged
Conversation
git_tools.py's clone/fetch SSH command had no BatchMode/ConnectTimeout, unlike the SSH probe in ssh_utils.py. A stalled network path (Tailscale half-up) or unauthorised deploy key hung the clone indefinitely with no output, since Executor.run() captures via pipes rather than streaming. Bound it to 15s so the existing retry/prompt logic actually engages instead of the process just sitting there. Executor.run() now polls via Popen + periodic communicate(timeout=15) instead of a single blocking subprocess.run(), logging "still running" so a slow command is distinguishable from a hung one. Same return/ exception semantics as before (verified: success, check=True failure with populated stdout/stderr, check=False, dry-run, interactive). Also stop assuming the wolfcraig key-copy hint's mDNS .local suffix resolves — it doesn't on a box that isn't on the same LAN (e.g. a cloud VM). Prefer the Tailscale IP, which is reachable regardless. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019nR4GeGS2EDhLypRNm1JhW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git_tools.py's clone/fetch SSH command had no BatchMode/ConnectTimeout, unlike the SSH probe in ssh_utils.py. A stalled network path (Tailscale half-up) or unauthorised deploy key hung the clone indefinitely with no output, since Executor.run() captures via pipes rather than streaming. Bound it to 15s so the existing retry/prompt logic actually engages instead of the process just sitting there.
Also stop assuming the wolfcraig key-copy hint's mDNS .local suffix resolves — it doesn't on a box that isn't on the same LAN (e.g. a cloud VM). Prefer the Tailscale IP, which is reachable regardless.
Claude-Session: https://claude.ai/code/session_019nR4GeGS2EDhLypRNm1JhW