Skip to content

Update the Adamantine logo - #484

Merged
Rombur merged 3 commits into
adamantine-sim:masterfrom
stvdwtt:update-logo
Jul 6, 2026
Merged

Update the Adamantine logo#484
Rombur merged 3 commits into
adamantine-sim:masterfrom
stvdwtt:update-logo

Conversation

@stvdwtt

@stvdwtt stvdwtt commented Jul 1, 2026

Copy link
Copy Markdown
Member

This now uses the the MDF-generated Adamantine logo. It does not update the QR code. If the documentation site points to these files, we may have to make edits there too.

@stvdwtt
stvdwtt requested a review from Rombur July 1, 2026 17:40

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project logos by adding new SVG assets (Adamantine-wordmark.svg and Adamantine.svg) and removing outdated SVG logo files. It also updates the logo reference in the README.md. The reviewer pointed out that the updated reference in README.md points to a non-existent .png file instead of the newly added .svg file, which would result in a broken image link.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread README.md Outdated
@@ -1,4 +1,4 @@
![image](doc/logo/adamantine_wordmark_with_bg.png)
![image](doc/logo/Adamantine-wordmark.png)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The image reference points to doc/logo/Adamantine-wordmark.png, but only the SVG version (doc/logo/Adamantine-wordmark.svg) was added in this pull request. To avoid a broken image link, please update the reference to use the .svg file or ensure the .png file is committed.

Suggested change
![image](doc/logo/Adamantine-wordmark.png)
![image](doc/logo/Adamantine-wordmark.svg)

@Rombur

Rombur commented Jul 6, 2026

Copy link
Copy Markdown
Member

If the documentation site points to these files, we may have to make edits there too.

It does. Any reason why you didn't overwrite the file instead of creating new ones?

@stvdwtt

stvdwtt commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

No good reason, let me fix that. I pushed a commit with filename changes, but I'll push another one that adds white background versions and reverts the README. I haven't found an easy way to update the QR code, but I'll try a couple more things.

@stvdwtt

stvdwtt commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

Reverted to previous file names and all files are now updated (including the QR code).

@Rombur

Rombur commented Jul 6, 2026

Copy link
Copy Markdown
Member

Looks good. Thanks.

I merging without waiting for the CI since the code is unchanged

@Rombur
Rombur merged commit 6036a00 into adamantine-sim:master Jul 6, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants