Jenkins CI: do not pull Docker image every time because we reach the rate limit - #486
Conversation
|
@codex please review this PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Jenkins configuration to disable alwaysPull for the Docker images. The reviewer warns that combining alwaysPull false with mutable image tags like latest and no_gpu-latest can cause environment drift and non-reproducible builds across CI runners, and recommends pinning the images to specific, immutable version tags instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| docker { | ||
| image "rombur/adamantine-stack:no_gpu-latest" | ||
| alwaysPull true | ||
| alwaysPull false |
There was a problem hiding this comment.
Using alwaysPull false with a mutable tag like no_gpu-latest can lead to environment drift across different CI runner nodes. If the image is updated on the registry, runners with a cached version of no_gpu-latest will not pull the new image, leading to non-reproducible builds. To ensure consistency, consider pinning the Docker image to a specific, immutable version tag.
| docker { | ||
| image "rombur/adamantine-stack:latest" | ||
| alwaysPull true | ||
| alwaysPull false |
There was a problem hiding this comment.
Using alwaysPull false with a mutable tag like latest can lead to environment drift across different CI runner nodes. If the image is updated on the registry, runners with a cached version of latest will not pull the new image, leading to non-reproducible builds. To ensure consistency, consider pinning the Docker image to a specific, immutable version tag.
|
Codex review is not enabled for this repo. Please contact the admins of this repo to enable Codex. |
Rombur
left a comment
Rombur
left a comment
There was a problem hiding this comment.
Reviewed by ChatGPT on behalf of Bruno Turcksin.
I reviewed the proposed change. The modification is straightforward: switching alwaysPull from true to false for both Jenkins Docker agents avoids repeated image pulls and addresses Docker Hub rate limiting while relying on manually refreshed images.
I did not identify any correctness issues with the change itself. The only suggestion is to document the operational assumption somewhere (either in ci/jenkins_config or CI documentation): the Docker images on Jenkins workers must be updated manually whenever rombur/adamantine-stack:* changes. Without that documentation, future maintainers may be surprised that CI is not automatically picking up newer container images.
Otherwise, this looks reasonable to me.
|
@codex please review this PR |
|
Codex review is not enabled for this repo. Please contact the admins of this repo to enable Codex. |
1 participant
The CI does not pass anymore because we reach the rate limit. Since we update the image once or twice a year, I'll just go on the different machines and update the images manually.
Second change: according to copilot the failure on the nix macos build is due to a problem upstream. I changed the CI, so that nix ubuntu runs even if nix macos fails