Open
Conversation
- Add `current time` property which replicates `AVAudioPlayer` property - Added test case for current time property
It will also address issue # 16 adamcichy#16
adamcichy
requested changes
Apr 4, 2020
Owner
adamcichy
left a comment
adamcichy
left a comment
There was a problem hiding this comment.
this PR is identical to your other PR. it would be better to create 2 separate branches. for feedback regarding the setVolume(...) method please see the other PR
Add support for macOS and tvOS minimum versions Co-authored-by: Adam Cichy <adam@moonlightapps.com>
Add support for macOS and tvOS minimum versions Co-authored-by: Adam Cichy <adam@moonlightapps.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetVolume with duration added as in AVAudioPlayer
It will also address issue # 16
#16