Open
Conversation
so now we can use .rate property to control the playback rate. https://developer.apple.com/documentation/avfoundation/avaudioplayer/1386118-rate
rauldeonate
approved these changes
Mar 28, 2020
rauldeonate
left a comment
rauldeonate
left a comment
There was a problem hiding this comment.
LGTM
Would be nice to add tests but we can work on them in another PR
adamcichy
reviewed
Apr 4, 2020
| for _ in 0..<playersPerSound { | ||
| do { | ||
| let player = try Sound.playerClass.init(contentsOf: url) | ||
| player.enableRate = true |
Owner
There was a problem hiding this comment.
why do you set enableRate to true by default? I'm guessing that AVAudioPlayer doesn't do it to improve performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so now we can use .rate property to control the playback rate.
https://developer.apple.com/documentation/avfoundation/avaudioplayer/1386118-rate