Skip to content

Support for $value and $type#8

Merged
adamghill merged 5 commits into
mainfrom
value-type
Sep 9, 2025
Merged

Support for $value and $type#8
adamghill merged 5 commits into
mainfrom
value-type

Conversation

@adamghill

@adamghill adamghill commented Sep 2, 2025

Copy link
Copy Markdown
Owner

@adamghill adamghill self-assigned this Sep 2, 2025
@adamghill
adamghill marked this pull request as draft September 4, 2025 11:55
@adamghill adamghill changed the title WIP: Support for $value and $type Support for $value and $type Sep 4, 2025
@adamghill

Copy link
Copy Markdown
Owner Author

@LucidDan curious what your thoughts are for these "types" here: https://github.com/adamghill/dj-toml-settings/pull/8/files#diff-6c843a10de40f74a1a40e896fb85fa99c940d122390c19afda9603189733b44cR145-R185.

I handled the ones from environs that made sense to me personally. Questions:

  • Getting back a ParseResult for "url" seems a little unintuitive
  • Not sure what "json" would return (or how useful it would be)

Any other thoughts are welcome!

@LucidDan

LucidDan commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

Work stuff has me unavailable for OSS stuff until the weekend, but I'll take a look on my Saturday!

@adamghill
adamghill marked this pull request as ready for review September 6, 2025 21:47
@adamghill

Copy link
Copy Markdown
Owner Author

I think this is ready to review. I need to look into the mypy errors and get test coverage back to 100%, but I'm pretty happy with this in general.

@adamghill
adamghill merged commit b3a6dc5 into main Sep 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants