-
Notifications
You must be signed in to change notification settings - Fork 5
Pin numpy to <2.0 to fix zarr compatibility #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
adamjtaylor
wants to merge
149
commits into
adamjtaylor:main
from
Sage-Bionetworks-Workflows:fix/numpy-version-constraint
Closed
Pin numpy to <2.0 to fix zarr compatibility #48
adamjtaylor
wants to merge
149
commits into
adamjtaylor:main
from
Sage-Bionetworks-Workflows:fix/numpy-version-constraint
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify docker image for dev environments
Update dockerfile for dev envs
Update dockerfile
…tch-1 Add badges to readme
Update ome_types version
Add logo to README.md
…fig, fix allOf references Co-authored-by: adamjtaylor <14945787+adamjtaylor@users.noreply.github.com>
Co-authored-by: adamjtaylor <14945787+adamjtaylor@users.noreply.github.com>
Co-authored-by: adamjtaylor <14945787+adamjtaylor@users.noreply.github.com>
Co-authored-by: adamjtaylor <14945787+adamjtaylor@users.noreply.github.com>
…tch-1 Fix samplesheet location for test profile
Co-authored-by: adamjtaylor <14945787+adamjtaylor@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: adamjtaylor <14945787+adamjtaylor@users.noreply.github.com>
…tional-save-for-images Feature merge into branch to unblock rapidly
Co-authored-by: adamjtaylor <14945787+adamjtaylor@users.noreply.github.com>
…oken-schema-references Fix broken schema references preventing Seqera Platform launch
…tional-save-for-images Add optional publishDir for bioformats2ometiff converted images
…d-failing Fix dockerfile
The zarr library uses np.PINF which was removed in NumPy 2.0. This constraint prevents pip installs from upgrading numpy beyond 1.x. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Owner
Author
|
Closing - PR was created on wrong repo. See Sage-Bionetworks-Workflows#41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
>=1.23.0,<2.0in Docker environmentProblem
The zarr library uses
np.PINFwhich was removed in NumPy 2.0. Pip installs in the Dockerfile can upgrade numpy beyond the conda-pinned version, causing this error:This blocks all CI tests including PR #37 (H&E RGB thumbnail generation).
Fix
Changed from exact pin
numpy=1.23.0to rangenumpy>=1.23.0,<2.0to prevent any numpy 2.x installation while allowing patch updates.Testing
Once merged, Docker container will rebuild automatically. This unblocks testing for PR #37.
🤖 Generated with Claude Code