Fix #130 - Google was not working due to lack of recursion #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attributes parsing
Owner
|
Thank you! I am surprised that this was not causing a problem with the test. Could you add a test-case to show what has changed? |
Author
|
Sure -- I'd be happy to. |
Author
|
Ok, after reviewing more, it looks like the tests are written for very different versions of the TF state files than I have. It shows version 4 in my terraform.tfstate file, and as best I can tell terraform-inventory is only meant to work with version 1 & 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to lack of recursion on attributes.