Skip to content

Conversation

@cgroschupp
Copy link
Contributor

No description provided.

@cgroschupp
Copy link
Contributor Author

@adammck Can you take a look at it?

@mcanevet
Copy link

This PR works fine. Thanks for it.
I think it could be improve though. Currently, the modules' outputs are located in [all:vars] section even though, I think, it would be more logical to have them in [<module_name>:vars].
@cgroschupp what do you think?

@mcanevet
Copy link

Actually, I think we should have a [root.<module_name>:children] section with all root.<module_name>.<resource_name> in it so that we can have a [root.<module_name>:vars] section. With this kind of inventory, all modules' output would be added as variables of all resources declared in the module.

@cgroschupp
Copy link
Contributor Author

@cryptobioz @mcanevet Thanks for the feedback.

@mcanevet
Copy link

@adammck would it be possible to merge this? IMHO it should even be the default behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants