Skip to content

Conversation

@adamralph
Copy link
Owner

@adamralph adamralph commented Dec 31, 2025

An attempt to order them from the most to least used, respecting the convention of CancellationToken last:

Run/RunAsync

 string workingDirectory = "",
-IEnumerable<string>? secrets = null,
-bool noEcho = false,
-string? echoPrefix = null,
 Action<IDictionary<string, string?>>? configureEnvironment = null,
-bool createNoWindow = false,
+IEnumerable<string>? secrets = null,
 Func<int, bool>? handleExitCode = null,
+string? echoPrefix = null,
+bool noEcho = false,
 bool cancellationIgnoresProcessTree = false,
+bool createNoWindow = false,
 CancellationToken ct = default,

ReadAsync

 string workingDirectory = "",
 Action<IDictionary<string, string?>>? configureEnvironment = null,
-Encoding? encoding = null,
 Func<int, bool>? handleExitCode = null,
+Encoding? encoding = null,
 string? standardInput = null,
 bool cancellationIgnoresProcessTree = false,
 CancellationToken ct = default,

@adamralph adamralph added this to the 13.0.0 milestone Dec 31, 2025
@adamralph adamralph added enhancement New feature or request breaking This change could break current consumers labels Dec 31, 2025
@adamralph adamralph merged commit 47bcc40 into main Dec 31, 2025
28 checks passed
@adamralph adamralph deleted the reorder-params branch December 31, 2025 22:57
@adamralph
Copy link
Owner Author

released in 13.0.0-rc.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking This change could break current consumers enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants